----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14436/#review26587 -----------------------------------------------------------
Ship it! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/14436/#comment51832> s/executor// All of our slave recovery tests, including this, use command executor which doesn't have any resources :( src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/14436/#comment51829> s/ack/_statusUpdateAcknowledgement/ src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/14436/#comment51830> s/, now/ so that/ src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/14436/#comment51831> Kill? - Vinod Kone On Oct. 2, 2013, 12:27 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14436/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 12:27 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-711 > https://issues.apache.org/jira/browse/MESOS-711 > > > Repository: mesos-git > > > Description > ------- > > This adds a test for https://reviews.apache.org/r/14435/ > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808 > > Diff: https://reviews.apache.org/r/14436/diff/ > > > Testing > ------- > > make check and ran with 1400 iterations. > > > Thanks, > > Ben Mahler > >
