How about adding an optional timestamp to TaskStatus?
On Wed, Oct 2, 2013 at 10:11 AM, Brenden Matthews <[email protected]>wrote: > > > > On Oct. 2, 2013, 5:54 a.m., Ben Mahler wrote: > > > include/mesos/mesos.proto, lines 372-373 > > > < > https://reviews.apache.org/r/14434/diff/1/?file=360207#file360207line372> > > > > > > I believe adding mutable fields to TaskInfo may be problematic as > in general the various components assume that _Info protobufs are immutable. > > > > > > A while back I had filed MESOS-296 in the same spirit: what if we > added timestamps to status updates? Status updates would still remain > immutable in the system. However, it's likely a bit trickier to show them > in the webui since the master does not expose status updates. One approach > is to have the master / slave track the {start,finish}_times in memory in > their respective Task structs. Thoughts? > > > > > > Even better would be if the webui could how a history of state > transitions (rather than status updates given how status updates can be > used as a messaging mechanism). > > I see, that was indeed a while back. > > If we add the same values to the in-memory structs, how do we report the > data back to the web UI? Currently the code in src/master/http.cpp just > pulls the values from the `Task` message. Is it safe to treat `Task` as > mutable? > > > - Brenden > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14434/#review26598 > ----------------------------------------------------------- > > > On Oct. 2, 2013, 12:18 a.m., Brenden Matthews wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/14434/ > > ----------------------------------------------------------- > > > > (Updated Oct. 2, 2013, 12:18 a.m.) > > > > > > Review request for mesos. > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > Added timestamps to TaskInfo. > > > > TaskInfo now includes a start/finish timestamp for each task. This is > > particularly for debugging framework problems. > > > > > > Diffs > > ----- > > > > include/mesos/mesos.proto 957576bbc1c73513a9591194d017f76fe562a616 > > src/master/http.cpp f2a535a002f07784db724f6fdedfb26b271d6327 > > src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a > > src/messages/messages.proto c599eb2f1105baf5253ab8c982f48f30e798b94f > > src/webui/master/static/framework.html > 6e5cd9f9e48597c7894d6381377c8a291014e8f3 > > > > Diff: https://reviews.apache.org/r/14434/diff/ > > > > > > Testing > > ------- > > > > `make check`, tested in staging, and manual web UI testing. > > > > > > Thanks, > > > > Brenden Matthews > > > > > >
