> On Oct. 7, 2013, 7:11 p.m., Vinod Kone wrote: > >
Also manipulated the clock so that the test does not take over a second to run (for the re-registration retry). > On Oct. 7, 2013, 7:11 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, lines 724-725 > > <https://reviews.apache.org/r/13757/diff/2/?file=361444#file361444line724> > > > > Do we need the slave in this test? Killing it would make this test much > > simpler! Thanks for catching this! > On Oct. 7, 2013, 7:11 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, lines 738-739 > > <https://reviews.apache.org/r/13757/diff/2/?file=361444#file361444line738> > > > > you can kill this if there is no slave. Thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13757/#review26745 ----------------------------------------------------------- On Oct. 4, 2013, 6:15 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13757/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 6:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-488 > https://issues.apache.org/jira/browse/MESOS-488 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-659. > > > Diffs > ----- > > src/master/master.cpp ce8365f082a5f96ef64e33e526cb5047dff52127 > src/tests/fault_tolerance_tests.cpp > 10e52c401476eb8416361de49b8e4061bb7ac4f3 > > Diff: https://reviews.apache.org/r/13757/diff/ > > > Testing > ------- > > Added a test that catches this case when not fixed. > > > Thanks, > > Ben Mahler > >
