> On Oct. 7, 2013, 7:14 p.m., Ben Mahler wrote: > > Should the pid be required or optional? Making it required seems to suggest > > that we're authenticating from a Process, but then in SASL tests UPID() is > > passed through, so in this case it seems optional.
It should be required. The SASL tests pass dummy pid because Authenticator itself doesn't need it. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14508/#review26746 ----------------------------------------------------------- On Oct. 5, 2013, 1:27 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14508/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2013, 1:27 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Sending pid in AuthenticateMessage is necessary because we have tests that > bring up multiple schedulers on the same ip:port. > > > Diffs > ----- > > src/messages/messages.proto c599eb2f1105baf5253ab8c982f48f30e798b94f > src/sasl/authenticatee.hpp e1e18fedd0255400b2c98356970c0c5d664f6034 > src/tests/sasl_tests.cpp 02e761b3506d7de1b0b693889f3d43e6872979c8 > > Diff: https://reviews.apache.org/r/14508/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
