----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14548/#review26804 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/14548/#comment52152> s/does not know about command executors/detects command executor's tasks by checking task.executor_id()/ ? src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/14548/#comment52154> s/update/update(s) of its task(s)) src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/14548/#comment52155> s/running// src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/14548/#comment52157> Consider using LaunchTasks action. That would eliminate a lot of this boilerplate. src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/14548/#comment52156> s/taask/task/ src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/14548/#comment52158> Great comments! - Vinod Kone On Oct. 8, 2013, 11:53 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14548/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2013, 11:53 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-420 > https://issues.apache.org/jira/browse/MESOS-420 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-420 for more context. This removes a CHECK in the master and > ensures the slave does not send Tasks with executor id's when for command > executors. > > > Diffs > ----- > > src/master/master.cpp cdfae1d46831c2de1fb535f60b38029fc1a0b9bb > src/slave/slave.cpp 0ad457647dbc7870d478de2eab3a744f3b8704c5 > src/tests/fault_tolerance_tests.cpp > 254eae4492a0047f1bdb26d9ba0c8ed66ef185b1 > > Diff: https://reviews.apache.org/r/14548/diff/ > > > Testing > ------- > > Added a test that fails without this patch. > make check > > > Thanks, > > Ben Mahler > >
