-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14509/#review26850
-----------------------------------------------------------

Ship it!



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/14509/#comment52220>

    Maybe "Expecting authentication principal in environment"



src/examples/balloon_framework.cpp
<https://reviews.apache.org/r/14509/#comment52221>

    Ditto.



src/examples/java/TestExceptionFramework.java
<https://reviews.apache.org/r/14509/#comment52227>

    Ditto?



src/examples/java/TestExceptionFramework.java
<https://reviews.apache.org/r/14509/#comment52228>

    Ditto.



src/examples/java/TestFramework.java
<https://reviews.apache.org/r/14509/#comment52229>

    Ditto again (and above).



src/examples/java/TestFramework.java
<https://reviews.apache.org/r/14509/#comment52230>

    What's with the sleeping? Comment!



src/examples/long_lived_framework.cpp
<https://reviews.apache.org/r/14509/#comment52222>

    Did you miss this one my friend?



src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/14509/#comment52223>

    Ditto above.



src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/14509/#comment52224>

    Ditto.



src/examples/python/test_framework.py
<https://reviews.apache.org/r/14509/#comment52231>

    Dittos (and above).



src/examples/test_framework.cpp
<https://reviews.apache.org/r/14509/#comment52225>

    Ditto.



src/examples/test_framework.cpp
<https://reviews.apache.org/r/14509/#comment52226>

    Ditto.


- Benjamin Hindman


On Oct. 8, 2013, 11:27 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14509/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 11:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-704
>     https://issues.apache.org/jira/browse/MESOS-704
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 1df5e2215aa10c0a26a00612eb75b3e53554fe63 
>   src/examples/java/TestExceptionFramework.java 
> 8ea55408686d898b52d3809afe216462127e64d1 
>   src/examples/java/TestFramework.java 
> 687ed0d012ccbb20ecb6830e9e86527273361298 
>   src/examples/long_lived_framework.cpp 
> 08ccc75df13467a1e823d35afe69cd0dc521fcf3 
>   src/examples/no_executor_framework.cpp 
> 3ffbbb7ad8df308ea2f55b6543fbaaf7ec7f212b 
>   src/examples/python/test_framework.py 
> eb2012735a075233850788b7e9d138a78447bae6 
>   src/examples/test_framework.cpp 0065de16c00a964959d1fceb824c436c20e992ee 
>   src/tests/allocator_tests.cpp e5dc0d7d9d547046e2c410a860f312761c8af58b 
>   src/tests/allocator_zookeeper_tests.cpp 
> 6e3214c15c14dc8ba82082738c172c8833cd0887 
>   src/tests/exception_tests.cpp 3fc1ac32d553644080a88f04f22077691ae1820b 
>   src/tests/fault_tolerance_tests.cpp 
> 10e52c401476eb8416361de49b8e4061bb7ac4f3 
>   src/tests/gc_tests.cpp e404de3bfacfcac5515995f1b45c3d39181e138f 
>   src/tests/isolator_tests.cpp cd3b3000060b379ef10e38a2a98a2eebe69d90fc 
>   src/tests/master_detector_tests.cpp 
> 2d140ba1a364a7af4d643951d6016ac17dd10526 
>   src/tests/master_tests.cpp 52f09d4f1ddeabcc1a797a13fae9641b72425dd5 
>   src/tests/mesos.hpp bc365fb17a25dbddaaffe0502c291f56a4b8f1a5 
>   src/tests/mesos.cpp 776cb0f13d10b4ae437fe9a3c97dc8b3481290af 
>   src/tests/resource_offers_tests.cpp 
> 3888e461de5c8fa807cff2fd2bd7ca12c704823a 
>   src/tests/script.cpp b4aef6be6fa26abf40a959dffeed75da16055737 
>   src/tests/slave_recovery_tests.cpp 097d43c1380274c8d2235d5c20f91c730f079355 
>   src/tests/status_update_manager_tests.cpp 
> cf420e4764356402f05b27c3b8e8802c21a58f8e 
> 
> Diff: https://reviews.apache.org/r/14509/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to