----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14510/#review26855 -----------------------------------------------------------
Ship it! src/tests/authentication_tests.cpp <https://reviews.apache.org/r/14510/#comment52232> s/.././ src/tests/authentication_tests.cpp <https://reviews.apache.org/r/14510/#comment52233> s/.././ src/tests/authentication_tests.cpp <https://reviews.apache.org/r/14510/#comment52234> What about adding another expectation to see another AuthenticateMessage? I.e., that we retried even though the master thought this framework was authenticated? In fact, getting another AuthenticationCompletedMessage would also imply that the master went through the authentication process again. - Benjamin Hindman On Oct. 8, 2013, 11:28 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14510/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2013, 11:28 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-704 > https://issues.apache.org/jira/browse/MESOS-704 > > > Repository: mesos-git > > > Description > ------- > > New tests added to specifically to test authentication. > > > Diffs > ----- > > src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147 > src/tests/authentication_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/14510/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
