----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14559/#review26879 -----------------------------------------------------------
Ship it! nice! support/mesos-style.py <https://reviews.apache.org/r/14559/#comment52306> pull this down above the for loop. support/mesos-style.py <https://reviews.apache.org/r/14559/#comment52307> Driver? - Vinod Kone On Oct. 10, 2013, 5:48 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14559/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2013, 5:48 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > To avoid style glitches, it would be handy to have a style checker to catch > the most common (and hard to find) errors such as whitespaces, tabs, line > widths and so forth. > While it is not likely to find a fully compatible style checker, Google's > cpplint can be configured to match a small subset of rules. > > This patch includes a wrapper, support/mesos-style.py, which runs cpplint on > mesos source (excluding 3rdparty libraries such as glog, protobuf, boost and > so on). > For now, only the whitespace/tab rule is active. When style errors gets > fixed, we can increase the verboseness of the applied rules. > > > Diffs > ----- > > support/cpplint.py PRE-CREATION > support/mesos-style.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14559/diff/ > > > Testing > ------- > > # python support/mesos-style.py > Checking 322 files... > src/detector/detector.cpp:142: Tab found; better to use spaces > [whitespace/tab] [1] > src/detector/detector.cpp:143: Tab found; better to use spaces > [whitespace/tab] [1] > ... > 3rdparty/libprocess/src/test-master.cpp:47: Tab found; better to use spaces > [whitespace/tab] [1] > Total errors found: 85 > > > Thanks, > > Niklas Nielsen > >
