----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14644/#review27000 -----------------------------------------------------------
I somehow missed Brenden's fix for this in the Master (here: https://reviews.apache.org/r/13599). We should probably just push that through reviews rather than complicating the webui any further, does that sound good? - Ben Mahler On Oct. 15, 2013, 1:52 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14644/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2013, 1:52 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-417 > https://issues.apache.org/jira/browse/MESOS-417 > > > Repository: mesos-git > > > Description > ------- > > Merged completed frameworks with duplicate IDs. > > It is possible for frameworks to register with duplicate IDs, in which > case using an ID in a URL is no longer specific enough to choose a > single framework. > > If there are completed frameworks with duplicate IDs, or if there is an > active framework with the same ID as completed ones, merge the relevant > values of the frameworks to create a single, uber framework. > > In the case of a completed framework duplicating an active framework, > delete the completed one so the uber version appears only as active. > > Fixes MESOS-417 > > > Diffs > ----- > > src/webui/master/static/framework.html > 6e5cd9f9e48597c7894d6381377c8a291014e8f3 > src/webui/master/static/js/controllers.js > 305aeaa195183c188e8ed949ccd67b49cbd757a0 > > Diff: https://reviews.apache.org/r/14644/diff/ > > > Testing > ------- > > > Thanks, > > Ross Allen > >
