> On Oct. 15, 2013, 1:29 a.m., Ben Mahler wrote: > > Seems weird to me that one must call stop() after abort(), perhaps we > > should include that in the scheduler.hpp documentation.
I think part of the reason is that stop() takes a 'failover' argument, which we can't guess from abort(). That said I updated the documentation for abort(). - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14640/#review26998 ----------------------------------------------------------- On Oct. 15, 2013, 12:19 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14640/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2013, 12:19 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Bugs: MESOS-738 > https://issues.apache.org/jira/browse/MESOS-738 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/examples/balloon_framework.cpp c4e87760b8498a5f0d1d6611d066509882a2b080 > src/examples/java/TestExceptionFramework.java > 4474a9167aee54ff31b90090b721ba76d6ea0860 > src/examples/java/TestFramework.java > 884a49d4420fcfee6211ec4c6afac534d0565104 > src/examples/long_lived_framework.cpp > 5b76939f64425505152ec0b98da9a2ef243fa749 > src/examples/no_executor_framework.cpp > 813e3fea78718c10d7c508b9e3b7ab182707c518 > src/examples/python/test_framework.py > fb8a730f047b129b4588e2a7a9e722e12db46492 > src/examples/test_framework.cpp ebfedf433e82ea4432f4c5276154605991faec3d > > Diff: https://reviews.apache.org/r/14640/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
