> On Oct. 22, 2013, 6:01 p.m., Brenden Matthews wrote: > > It may also be worth looking at these: > > > > https://reviews.apache.org/r/11108/ > > https://reviews.apache.org/r/11975/ > > > > This is how we accomplish the same thing. > > Niklas Nielsen wrote: > Hi Brenden, > > Thanks for the pointers! > > Was there any particular push-back or things to be resolved since #11975 > haven't landed yet? > The patch would need to be rebased again to work, unfortunately. > > Niklas > > Brenden Matthews wrote: > I'll update both of those in review board. I haven't changed anything > since I wrote them initially. My understanding is that someone else was also > working on rewriting this code, though I do not know the status of that. > > Brenden Matthews wrote: > I attempted (and failed) to update the diffs, but I included a link to > the updated patch.
I think adding a 'hostname' flag is a good step regardless of how we figure out what's the right way to get a hostname if none is specified (i.e., Brenden's patch at https://reviews.apache.org/r/11108). That is, multiple hostnames may map to the same IP and this lets a user specify which hostname they want us to publish. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14847/#review27314 ----------------------------------------------------------- On Oct. 22, 2013, 5:41 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14847/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 5:41 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > A slave can be started with --hostname which explicitly sets hostname instead > of usual system hostname. > This is necessary in situations where system hostname resolves to internal > names which cannot be accessed from the web ui. > > > Diffs > ----- > > include/mesos/mesos.proto fe1d82b > src/common/type_utils.hpp c48411f > src/slave/flags.hpp db777e3 > src/slave/slave.cpp debb2f4 > src/tests/script.cpp e6a935f > src/tests/state_tests.cpp f39dee5 > > Diff: https://reviews.apache.org/r/14847/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
