----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14657/#review27389 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Oct. 22, 2013, 6:16 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14657/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 6:16 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Removed unimplemented Dashboard page. > > The Dashboard page has been stubbed in the webUI for a while but has not > received any attention yet. It is misleading when a user clicks on the > navigation and doesn't understand what the graphs mean. > > The files are not used for anything else, and so they can safely be > removed without affecting the rest of the UI. D3 and Cubism can be > re-added later if they prove useful. > > Review: https://reviews.apache.org/r/14657 > > > Diffs > ----- > > src/Makefile.am a2d82425f74dcaf3adf28ae8184fff53b3c34ceb > src/webui/master/static/css/graph.css > a0d9022ae8ede656d6d7e8c294f4de9330d23cc7 > src/webui/master/static/dashboard.html > ca7c73ae96a346d5e33a342b21d9cc0692679424 > src/webui/master/static/index.html ce504aac56a7fd921d71a09b76050c75bf203be2 > src/webui/master/static/js/app.js 92e8e2dd36091f109be3cf3ce26fd23f558e6890 > src/webui/master/static/js/controllers.js > 305aeaa195183c188e8ed949ccd67b49cbd757a0 > src/webui/master/static/js/cubism.v1.js > f09f00f7480d711f259dd0d4d33e1a9cbc7c0f9c > src/webui/master/static/js/cubism.v1.min.js > 16aa4bae8f525f7368fa41a73502ede2e6fa4395 > src/webui/master/static/js/d3.v2.js > f1adefd17c01f439b9c974ea12a5df3aa574e2b1 > src/webui/master/static/js/d3.v2.min.js > 0b4ea58fdb3898737cf1be2c06ce6d7532e87878 > > Diff: https://reviews.apache.org/r/14657/diff/ > > > Testing > ------- > > Ran `make`. > Rendered each page of the web UI. > > > Thanks, > > Ross Allen > >
