----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14812/#review27397 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp <https://reviews.apache.org/r/14812/#comment53245> Why do you look at argv[0]? 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp <https://reviews.apache.org/r/14812/#comment53246> You could clean this up a bit by moving the name, value down and killing the else block: if (arg.find("--") != 0) { continue; } std::string name; Option<std::string> value; if (eq == ....) - Ben Mahler On Oct. 21, 2013, 11:58 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14812/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 11:58 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 6cd4c48349c2c296816e521f6a015a6cb03a96cc > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > 2809280951da562a59914c6c619162d739b38a89 > > Diff: https://reviews.apache.org/r/14812/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
