----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14814/#review27401 -----------------------------------------------------------
Ship it! src/detector/detector.cpp <https://reviews.apache.org/r/14814/#comment53248> Can you add a little note here that we're handing off pointer ownership to libprocess? - Ben Mahler On Oct. 21, 2013, 11:58 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14814/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 11:58 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0 > src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e > > Diff: https://reviews.apache.org/r/14814/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
