> On Oct. 23, 2013, 9:17 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 2343-2419 > > <https://reviews.apache.org/r/14663/diff/2/?file=369935#file369935line2343> > > > > We should likely check if it exists rather than crashing if we cannot > > update the utime: > > > > if (os::exists(path)) { > > // There is a race here if it gets deleted underneath us! > > CHECK_SOME(os::utime(path)); // Update the modification time. > > garbageCollect(path); > > } > > > > Or simply omit the CHECK_SOME: > > os::utime(path); > > garbageCollect(path); > > > > Or only garbageCollect if we can update the time: > > if (os::utime(path).isSome()) { > > garbageCollect(path); > > } > > > > It seems like there are cases where some of these files could be > > non-existent and we should not crash in these cases.
Good call. Removed the check. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14663/#review27421 ----------------------------------------------------------- On Oct. 23, 2013, 7:45 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14663/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 7:45 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-742 > https://issues.apache.org/jira/browse/MESOS-742 > > > Repository: mesos-git > > > Description > ------- > > Old recovered directories are now gc'ed based on modification time. > > > Diffs > ----- > > src/slave/slave.hpp 22fb74b71a0f52d9d67b92ecc286fa8d350e41a4 > src/slave/slave.cpp debb2f4ce05fbfec450197e68bc8a0c78f1d0adf > > Diff: https://reviews.apache.org/r/14663/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
