----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14900/#review27473 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/protobuf.hpp <https://reviews.apache.org/r/14900/#comment53393> kill this? - Vinod Kone On Oct. 24, 2013, 3:36 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14900/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 3:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-765 > https://issues.apache.org/jira/browse/MESOS-765 > > > Repository: mesos-git > > > Description > ------- > > This moves ProtobufProcess::from from protected to private. In order for > message handlers to know the sender's UPID, they now pass a handler that > takes a UPID as the first argument. Internally, this will pass the sender's > pid to the handler. > > This part is optional, in that all previous handlers will work fine, so long > as they do not access 'from'. For those that access 'from', the handler must > now take a UPID as a first argument to be passed the sender explicitly. > > See MESOS-765. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > b502324361c38ba6280c937d53cb2fe125193126 > 3rdparty/libprocess/include/process/protobuf.hpp > e0338d979d2d58eb757662e4ff1d97587a93a2ee > > Diff: https://reviews.apache.org/r/14900/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
