-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14901/
-----------------------------------------------------------
(Updated Oct. 24, 2013, 7:30 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's review:
-> Killed some redundant checks now that we've removed the need for
_registerFramework and _reregisterFramework.
-> Used 'from' as the sender argument name for all handlers. This results in a
much smaller diff.
Bugs: MESOS-765 and MESOS-769
https://issues.apache.org/jira/browse/MESOS-765
https://issues.apache.org/jira/browse/MESOS-769
Repository: mesos-git
Description
-------
These are the necessary adjustments for: https://reviews.apache.org/r/14900/
These removes the now unnecessary continuations in the Master that were added
for authentication.
I actually uncovered a bug in Master::authenticate while doing this!
Master::authenticate uses 'from', but we defer() back to Master::authenticate
when we need to retry, thus ensuring 'from' is stale (from == UPID() in the
deferred context!).
Diffs (updated)
-----
src/exec/exec.cpp 7ca21fa205ee8cb851dc8d826d75d8d438c36860
src/master/master.hpp 9f5e25b2f67efd85090cfd0f8bcc916cd6751cbf
src/master/master.cpp f838a9da41a9a0ba99f3ad0a6aa70903c17886f5
src/sasl/authenticatee.hpp 09ef018b0ea5d0eb8af753aa2be43f4431b82d87
src/sched/sched.cpp 824b4b750511475c111be6e3fc5f5461448b3045
src/slave/slave.hpp 22fb74b71a0f52d9d67b92ecc286fa8d350e41a4
src/slave/slave.cpp debb2f4ce05fbfec450197e68bc8a0c78f1d0adf
src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
Diff: https://reviews.apache.org/r/14901/diff/
Testing
-------
make check
Thanks,
Ben Mahler
