-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14951/#review27576
-----------------------------------------------------------



src/cli/mesos-cat
<https://reviews.apache.org/r/14951/#comment53512>

    This might read better as:
    
    "Failed to resolve 'mesos-resolve %s'\n" % master 



src/cli/mesos-cat
<https://reviews.apache.org/r/14951/#comment53511>

    Might want to use `-sSfL` for the `curl` options. With `-f`, `curl` 
translates HTTP failures (400s, 500s) to non-zero exit codes. With `-L` it 
follows redirects. With `-S` it is silent except when there are errors; then it 
prints a helpful message to `stderr`.  



src/cli/mesos-tail
<https://reviews.apache.org/r/14951/#comment53513>

    Same as line 30 in mesos-cat.



src/cli/mesos-tail
<https://reviews.apache.org/r/14951/#comment53514>

    Same as line 52 in mesos-cat.


- Jason Dusek


On Oct. 26, 2013, 2:01 a.m., Shingo Omura wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14951/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2013, 2:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> These are actually slightly improved version of the original shared by Ben.H 
> at mesos hackathon on Oct.25th 2013.
> 
> Modifications I did:
> - add python version check
> - add quote for query contents
> - support to inspect files on completed frameworks/tasks
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-cat PRE-CREATION 
>   src/cli/mesos-tail PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14951/diff/
> 
> 
> Testing
> -------
> 
> I tested these manually on my laptop.
> 
> 
> Thanks,
> 
> Shingo Omura
> 
>

Reply via email to