-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15015/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs: Mesos-758
https://issues.apache.org/jira/browse/Mesos-758
Repository: mesos-git
Description
-------
This reports a basic break down of memory usage so jobs whose page
cache expands to their configured hard limit will have information
that allows them to size their jobs.
This does not include all fields from memory.stat and not even all
total_ fields from memory.stat but rather the fields I have reviewed
and seen a need for, and have a reasonable expectation that the fields
will report useful information and work as designed.
Quite a few of the fields appear only useful for kernel level debugging.
In particular the fields:
memory.stat:total_cache which reports the amount of file backed memory
in bytes
memory.stat:total_rss which reports the amount of anonymous memory in
bytes
memory.stat:total_mapped_file which reports the amount of mapped file memory
in bytes
Reading memory.stat is not quite atomic and neither is computing the
values. As even in the simplest cases the values are sums of per cpu
counters of the various statistics. However for the most part the numbers are
a reasonable
snapshot of the state of the cgroup at a particular instant.
Diffs
-----
include/mesos/mesos.proto fe1d82b
src/slave/cgroups_isolator.cpp fc36f1f
src/slave/monitor.cpp 9cb6256
src/tests/monitor_tests.cpp 3d3f8af
Diff: https://reviews.apache.org/r/15015/diff/
Testing
-------
make and make check pass
The code is a trivial extension of what already exists.
Thanks,
Eric Biederman
