----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/#review27842 -----------------------------------------------------------
Just a few style/white space comments. src/cli/cli_utils.py <https://reviews.apache.org/r/14960/#comment54195> Kill new line? src/cli/cli_utils.py <https://reviews.apache.org/r/14960/#comment54187> Usual style is TODO(<your handle>): <comment>. So it becomes: TODO(duli): to be cleaned up further, e.g., sys.exit should perhaps not be used. src/cli/cli_utils.py <https://reviews.apache.org/r/14960/#comment54188> Can you kill white space? src/cli/mesos-status <https://reviews.apache.org/r/14960/#comment54190> Kill white space src/cli/mesos-status <https://reviews.apache.org/r/14960/#comment54206> Kill this line if it is not needed? src/cli/mesos-status <https://reviews.apache.org/r/14960/#comment54192> Kill white space src/cli/mesos-status <https://reviews.apache.org/r/14960/#comment54201> s/dict/dictionary/ ? Words are usually spelled out. src/cli/mesos-status <https://reviews.apache.org/r/14960/#comment54203> Comment on its own line. src/cli/mesos-status <https://reviews.apache.org/r/14960/#comment54193> Kill trailing white space - Niklas Nielsen On Oct. 25, 2013, 11:40 p.m., Du Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14960/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 11:40 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > This commit implements the CLI command mesos-status, which reports three > categories of hosts: > > (1) live -- The hosts that are reported by the master/state.json and > responded correctly to monitor/statistics.json query; > (2) dead -- Those that are reported by master but responded incorrectly to > query; > (3) not running -- Those that are included in the var/mesos/deploy/slaves > files but not reported by the master. > > In addition, the two functions ulimit and resolve are extracted from the > original mesos-ps file as module cli_utils.py because they could be reused in > other CLI commands. > > > Diffs > ----- > > src/cli/cli_utils.py PRE-CREATION > src/cli/mesos-ps a6a8e9b > src/cli/mesos-status PRE-CREATION > > Diff: https://reviews.apache.org/r/14960/diff/ > > > Testing > ------- > > tested on single-host deployment of mesos. > > > Thanks, > > Du Li > >
