----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14952/#review27937 -----------------------------------------------------------
Has this been obviated by your new review? https://reviews.apache.org/r/15112 - Ben Mahler On Oct. 25, 2013, 10:31 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14952/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 10:31 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See title. Make sure we don't accidentally do the following: > > void func(const Shared<Foo>& foo) {...} > > Foo* foo = new Foo(); > func(foo); > delete foo; > > > Diffs > ----- > > 3rdparty/libprocess/include/process/shared.hpp faa11cc > > Diff: https://reviews.apache.org/r/14952/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
