-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15154/
-----------------------------------------------------------

(Updated Oct. 31, 2013, 10:55 p.m.)


Review request for mesos.


Summary (updated)
-----------------

Preferred ng-show to jQuery for #no-leader-alert.


Repository: mesos-git


Description (updated)
-------

Preferred ng-show to jQuery for #no-leader-alert.

Mixing jQuery DOM access with Angular creates two locations for state
storage. Always prefer Angular to jQuery for changing the DOM.

* Removed the "Close" button because the alert is not dismissable.


Diffs
-----

  src/webui/master/static/index.html 47403d8dc407a454e011262d3614197e49f159ca 
  src/webui/master/static/js/controllers.js 
0c930a2101af2d95bd003d8860602f9e3dd26fba 

Diff: https://reviews.apache.org/r/15154/diff/


Testing
-------


Thanks,

Ross Allen

Reply via email to