----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15161/#review28038 -----------------------------------------------------------
Looking good Shingo! src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54545> s/){/) {/ src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54544> Can you add spaces: s/if(/if (/ s/){/) {/ src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54546> s/}else{/} else {/ src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54543> We wrap lines at 80 characters, can you wrap this line? - Ben Mahler On Nov. 1, 2013, 9:15 p.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15161/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 9:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > some improvement for mesos-execute. > - reports framework-id and task-id. > - check if offer resource has enogh > - guarantee that only one task will be commited. > > > Diffs > ----- > > src/cli/execute.cpp ac2f299 > > Diff: https://reviews.apache.org/r/15161/diff/ > > > Testing > ------- > > tested on my laptop, single host deployment. > $ bin/mesos-execute --master=192.168.33.1:5050 --name=echo --command="echo > hello" > I1101 14:13:31.044026 238424064 sched.cpp:220] No credentials provided. > Attempting to register without authentication > Framework registered with 201311011326-18983104-5050-55224-0007 > task echo submitted to slave 201310311751-16777343-5050-26811-0 > Received status update TASK_RUNNING for task echo > Received status update TASK_FINISHED for task echo > > > Thanks, > > Shingo Omura > >
