> On Nov. 4, 2013, 6:23 p.m., Ben Mahler wrote: > > Can you easily guard that whole check to occur only for gcc? (When using > > clang we don't want the same version check).
Good point. Clang will claim to be a GCC 4.2.1 with dumpversion. We could have something as simple as: gcc --version|grep clang > /dev/null if test $? == 0; then # This is a clang compiler # ... else # This is a real GCC # ... fi - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15193/#review28125 ----------------------------------------------------------- On Nov. 2, 2013, 2:27 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15193/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2013, 2:27 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This has caused problems in settings where the desired compiler isn't the > system bundled GCC (as in Mac OS X Mavericks builds where we have been using > specific versions of GCC). > > Review #14164 is re-enabled for $(CC) instead of 'gcc' and lets us compile > with GCC 4.8 on Mavericks instead of down-grading to 4.7. > > > Diffs > ----- > > configure.ac ac3f7f7 > > Diff: https://reviews.apache.org/r/15193/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
