To close the loop, we decided to fix the issue rather than revert. Thanks BenH for the quick fix!
https://reviews.apache.org/r/15214/ On Mon, Nov 4, 2013 at 1:04 PM, Benjamin Hindman <[email protected]>wrote: > Hey Vinod, > > Unless I'm missing something, I don't see any incompatibilities (the > webui_hostname and webui_port have been deprecated for some time now and > should not have been used anywhere in the code base, thus their removal). > > Please see my other comments on the review. Also, I'd love to keep this > conversation in one place (at Review Board) please. > > Thanks! > > Ben. > > > On Mon, Nov 4, 2013 at 10:44 AM, Vinod Kone <[email protected]> wrote: > > > Hey folks, > > > > I think there are some backwards compatibility issues with > > https://reviews.apache.org/r/14847/. I've added my comment on the review > > for those that are interested. > > > > I would like to revert this commit for now until we have a proper fix. > > > > Niklas: Are there any other commits that depend on this? Is it safe to > > revert? > > > > Thanks, > > >
