----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15016/#review28161 -----------------------------------------------------------
src/zookeeper/group.cpp <https://reviews.apache.org/r/15016/#comment54777> Add a TODO to re-use the peer constructor when we have C++11. (Not a big deal, I would just like to have a nice way to track cleanups when we make the switch). (See: http://en.wikipedia.org/wiki/C++11#Object_construction_improvement for what I'm talking about). src/zookeeper/group.cpp <https://reviews.apache.org/r/15016/#comment54779> What happens if cancel returns false? We'll set the timer to None() but there's an impending call to timedout() in the queue? Is that intended? src/zookeeper/group.cpp <https://reviews.apache.org/r/15016/#comment54781> Why is this CHECK safe? Is it safe because expired() is always called before reconnecting()? src/zookeeper/group.cpp <https://reviews.apache.org/r/15016/#comment54782> If you fail to cancel it you'll have a pending call to timedout(), are you assuming that the Timer will not become SOME before the event for timedout() is processed? - Ben Mahler On Nov. 5, 2013, 12:39 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15016/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 12:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/zookeeper/group.hpp 6b6c1557658df1bb7b7df3ded5c203e2dc0c8308 > src/zookeeper/group.cpp cd58d230a2715b9ed01002443ebd7b5366d31be6 > > Diff: https://reviews.apache.org/r/15016/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
