> On Nov. 6, 2013, 4:44 a.m., Benjamin Hindman wrote:
> > src/tests/log_tests.cpp, lines 1068-1069
> > <https://reviews.apache.org/r/14902/diff/5/?file=377554#file377554line1068>
> >
> > Hmm, I'm not sure what you're testing. Do you want to look at the
> > result of this?
This was initially put there to expose the seg fault bug before Shared<Network>
was introduced. Now that the last line won't seg fault, I supposed it could
just be:
result = coord2.elect(Timeout::in(Seconds(1)));
ASSERT_TRUE(result.isNone());
I have revised it along with other newly added tests but have yet to submit it.
Perhaps this test can be dropped from this patch and go with the rest of the
tests.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14902/#review28255
-----------------------------------------------------------
On Nov. 5, 2013, 12:50 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14902/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 12:50 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-736
> https://issues.apache.org/jira/browse/MESOS-736
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Libprocessify the coordinator.
>
>
> Diffs
> -----
>
> src/log/coordinator.hpp 3f6fb7c
> src/log/coordinator.cpp 6e6466f
> src/tests/log_tests.cpp ff5f86c
>
> Diff: https://reviews.apache.org/r/14902/diff/
>
>
> Testing
> -------
>
> bin/mesos-tests.sh --gtest_filter=*CoordinatorTest*:*LogTest*:*ReplicaTest*
> --gtest_repeat=100
>
>
> Thanks,
>
> Jie Yu
>
>
