----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15099/#review28384 -----------------------------------------------------------
src/master/registrar.cpp <https://reviews.apache.org/r/15099/#comment55205> If there is a network partition with the zk are we going to wait forever? Are we assuming this is ok because the leading master would eventually commit suicide if there is a partition? src/master/registrar.cpp <https://reviews.apache.org/r/15099/#comment55208> How is this possible? i.e., update() is called when there are no mutations. - Vinod Kone On Nov. 5, 2013, 2:34 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15099/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 2:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This is addressing my comments on https://reviews.apache.org/r/14383/ > > > Diffs > ----- > > src/master/registrar.hpp 5742c365bac0082efea53c35333d3c3503494066 > src/master/registrar.cpp 42fe30ededd004e380abc835c224649e02999f11 > src/master/registry.proto bd850997c57153cdfc0c39d0dae7d2b802034aa3 > src/tests/registrar_tests.cpp 51975f5aa2725f64d2a83387a381e5078c8b9e1d > > Diff: https://reviews.apache.org/r/15099/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
