----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15302/#review28402 -----------------------------------------------------------
Ship it! Thanks for fixing this! - Ben Mahler On Nov. 7, 2013, 8:40 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15302/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 8:40 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > This was causing issues with mesos-cat (and thus likely mesos-tail too) > because when a file didn't exist Files was returning Bad Request 400 instead > of Not Found 404. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 18d8b7fbee52dab58551a0fc66edb6c37e4b1425 > src/cli/mesos.cpp fbdc3b9c33ebbce46f7dcf0e89dbf4d511de2c37 > src/files/files.cpp 69d68523b0e2a8578ff3ec1c633c61a7d29dd007 > src/linux/cgroups.cpp f1aec3f2b6dae75cd67ba4f100589093a4c7c1e7 > src/slave/process_isolator.cpp fa8029325122f6b1f4ce2ea8492e7a33a7a982f3 > src/slave/slave.cpp 90575db0ed9ce0953745cc23460fbcda240c7c0e > src/slave/state.cpp c675b4c77f5b2ac12d9080973d103239a13678de > src/tests/flags.hpp 071f138124af811ff2bde78788f04f8df2a6adea > src/tests/script.cpp b3bbf8723ffbcea5d8200790f704891d8026fa83 > > Diff: https://reviews.apache.org/r/15302/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
