----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15114/#review28427 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/15114/#comment55246> Just make this a no-op. src/master/master.cpp <https://reviews.apache.org/r/15114/#comment55247> delete whitelistWatcher. src/master/master.cpp <https://reviews.apache.org/r/15114/#comment55250> Can you use protobuf::createStatusUpdate()? src/master/master.cpp <https://reviews.apache.org/r/15114/#comment55251> How about a return here too? src/master/master.cpp <https://reviews.apache.org/r/15114/#comment55252> if (slave == NULL) { LOG... return; } src/master/master.cpp <https://reviews.apache.org/r/15114/#comment55253> Why did you pull this out when it's used only once? src/master/master.cpp <https://reviews.apache.org/r/15114/#comment55254> How is slave->executors.contains(frameworkId) not possible? Didn't you just get the key above? - Vinod Kone On Nov. 1, 2013, 6:17 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15114/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 6:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This is to minimize the size of the diff I end up sending for the stateful > master implementation. There should be no functional change here. > > > Diffs > ----- > > src/master/master.hpp e377af8b3ccd932ae411fa2df4c19642a7310d02 > src/master/master.cpp 8e14a070e87ebe579b54d05fb1e8b286edb5e459 > > Diff: https://reviews.apache.org/r/15114/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
