> On Nov. 7, 2013, 7:05 p.m., Ben Mahler wrote: > > src/cli/python/mesos/cli.py, line 4 > > <https://reviews.apache.org/r/15300/diff/1/?file=380407#file380407line4> > > > > Should we just do the newline printing here and avoid the callers > > having to always add a \n?
Sounds good to me, updated. > On Nov. 7, 2013, 7:05 p.m., Ben Mahler wrote: > > src/cli/python/mesos/cli.py, lines 35-44 > > <https://reviews.apache.org/r/15300/diff/1/?file=380407#file380407line35> > > > > 'cli.get' seems a bit non-obvious that we're doing an http get. > > > > Can you capitalize get in the comment here? s/HTTP get/HTTP GET/ Okay, I moved it into the 'mesos.http' namespace. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15300/#review28403 ----------------------------------------------------------- On Nov. 7, 2013, 8:42 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15300/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 8:42 a.m.) > > > Review request for mesos, Ben Mahler, Du Li, Shingo Omura, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/cli/mesos-ps 0d1694e3b2e9c8f4932102dbd633888e81470008 > src/cli/python/mesos/cli.py 7712886ceaaecd96347111f99a2c89d1e62bd5e2 > > Diff: https://reviews.apache.org/r/15300/diff/ > > > Testing > ------- > > $ mesos ps --master=... > > > Thanks, > > Benjamin Hindman > >
