----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15200/#review28559 -----------------------------------------------------------
Great! Yeah we can think about % CPU usage later, for now this looks good! Just a few stylistic things left. :) src/cli/mesos-ps <https://reviews.apache.org/r/15200/#comment55363> 0? src/cli/mesos-ps <https://reviews.apache.org/r/15200/#comment55364> Can you add a ':' after the TODO? s/TODO(everpeace)/TODO(everpeace):/ src/cli/mesos-ps <https://reviews.apache.org/r/15200/#comment55370> Hey Shingo, what if instead of having two functions here (dataUnit and dataSize), it seems like we just want to format a byte variable into a string. If you look in src/webui/master/static/js/app.js we use a single function called dataSize that takes a byte amount and converts it to a string. PEP8 advocates for using snake_case for naming functions, so data_size would be better: http://www.python.org/dev/peps/pep-0008/#function-names Does that sound better? src/cli/mesos-ps <https://reviews.apache.org/r/15200/#comment55365> s/CPU(allocated)/CPUS (allocated)/ - Ben Mahler On Nov. 8, 2013, 6:54 a.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15200/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 6:54 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Du Li, and Niklas > Nielsen. > > > Repository: mesos-git > > > Description > ------- > > I think it would be better mesos-ps reports allocated cpus and used/allocated > memory. > > > Diffs > ----- > > src/cli/mesos-ps f32c812 > > Diff: https://reviews.apache.org/r/15200/diff/ > > > Testing > ------- > > tested on my laptop, single host deployment. > -(~/Documents/githubs/everpeace/mesos/build)- > $ ./bin/mesos.sh ps --master=192.168.33.1:5050 > USER FRAMEWORK TASK SLAVE MEM TIME > CPU(allocated) > omura echo5 shingo-no-macbo... 8.0 MB/1.0 GB > 00:00:00.090137 1 > omura echo5 shingo-no-macbo... 9.0 MB/128.0 MB > 00:00:02.983559 1 > > > Thanks, > > Shingo Omura > >
