----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15336/#review28672 -----------------------------------------------------------
Ship it! itertools.chain really cleans this up! Just a few stylistic notes below, otherwise looks good! src/cli/mesos-tail <https://reviews.apache.org/r/15336/#comment55592> We should likely confine the try/except to only surround the call to http.get: try: result = http.get(...) except: ... if len(result['data']) == 0: ... src/cli/mesos-tail <https://reviews.apache.org/r/15336/#comment55590> You can omit the \n on your usage() calls, since usage() now prints the newline for you. - Ben Mahler On Nov. 9, 2013, 2:44 a.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15336/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2013, 2:44 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Du Li, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See Summary. > > > Diffs > ----- > > src/cli/mesos-tail f4f7c75 > > Diff: https://reviews.apache.org/r/15336/diff/ > > > Testing > ------- > > mesos tail --master=... --framework=... --task=... --file=... > > > Thanks, > > Shingo Omura > >
