> On Nov. 14, 2013, 7:19 p.m., Ross Allen wrote: > > src/webui/master/static/js/controllers.js, line 224 > > <https://reviews.apache.org/r/14434/diff/7/?file=384705#file384705line224> > > > > All other timestamps in JS are unmodified, stored as seconds, and then > > the '* 1000' is done in the view. Let's stick to that here too. > > > > The '* 1000' in the view is gnarly, but we can move that into the > > 'isoDate' filter afterward. > > Brenden Matthews wrote: > Oh no, just a few moments too late :) > > I'll open another review for this.
https://reviews.apache.org/r/15539/ - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14434/#review28886 ----------------------------------------------------------- On Nov. 14, 2013, 7:16 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14434/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 7:16 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Added list of TaskStatuses to Task message. > > Task now includes repeated task status with timestamps. This permits > caltulating the start/finish time for tasks (among other things). > > To support this, a timestamp was added to the TaskStatus message which > is also passed to frameworks when there are state transitions. > > Review: https://reviews.apache.org/r/14434 > > > Diffs > ----- > > include/mesos/mesos.proto ad4ba5bb618d4c9e107e288566852f54da6ceea5 > src/common/protobuf_utils.hpp 19a49ab1cb212b454394b78ffedeb9a7eb6b8964 > src/exec/exec.cpp 4a598f52bd9f97eeb14d9700e05281ccc1650c14 > src/master/http.cpp f2a535a002f07784db724f6fdedfb26b271d6327 > src/master/master.cpp 8e14a070e87ebe579b54d05fb1e8b286edb5e459 > src/messages/messages.proto a5dded2c0f3f88a5f7d789ccde6e59f68880374b > src/slave/slave.hpp 68526f3fb01be6dc19d7e3c8e4ba8220b2c56ccb > src/slave/slave.cpp 13cb41828298a725ee94a900a63dd8626f315e7e > src/webui/master/static/framework.html > 6e5cd9f9e48597c7894d6381377c8a291014e8f3 > src/webui/master/static/frameworks.html > 7c243d47d80e7c74fcac938d012b91b67b995490 > src/webui/master/static/js/controllers.js > 8f65679ff4f82f570cf7d632e45ca7dbcfab3376 > > Diff: https://reviews.apache.org/r/14434/diff/ > > > Testing > ------- > > `make check`, tested in staging, and manual web UI testing. > > > Thanks, > > Brenden Matthews > >
