----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15597/#review29063 -----------------------------------------------------------
Ship it! Can you kill the sleep in CommandExecutor now? That would be one way to test this fix. - Vinod Kone On Nov. 15, 2013, 10:15 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15597/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 10:15 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-243 > https://issues.apache.org/jira/browse/MESOS-243 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-243, currently driver.join() will not wait for outstanding > requests. This ensures any outstanding requests when driver.{stop|abort}() is > called will be flushed prior to driver.join() returning. See sched.cpp for > how this mirror the SchedulerDriver functionality. > > > Diffs > ----- > > src/exec/exec.cpp c866838c90901610803df026329060c170d9f21a > > Diff: https://reviews.apache.org/r/15597/diff/ > > > Testing > ------- > > make check (surprised none of our tests sleep to compensate..?) > > > Thanks, > > Ben Mahler > >
