-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15724/#review29189
-----------------------------------------------------------



src/master/http.cpp
<https://reviews.apache.org/r/15724/#comment56336>

    Any reason to avoid JSON::Protobuf? It was created to eliminate this 
boilerplate:
    
    return JSON::Protobuf(frameworkInfo);
    
    at which point this model function seems unnecessary


- Ben Mahler


On Nov. 20, 2013, 8:01 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15724/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 8:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Ross Allen.
> 
> 
> Bugs: MESOS-824
>     https://issues.apache.org/jira/browse/MESOS-824
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 218906a0c1f056faa30213e10f2f7762b518ecc8 
>   src/slave/http.cpp 2f0bd8d63cdd3fce4e0fb401e818f828baf1447e 
> 
> Diff: https://reviews.apache.org/r/15724/diff/
> 
> 
> Testing
> -------
> 
> Tested locally by hitting the endpoints.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to