----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15741/#review29199 -----------------------------------------------------------
Ship it! Maybe the better strategy is to set the work directory in the scripts as was done in the balloon test, ensuring that cleanup happens at exit? Otherwise the test scripts when run standalone will leak in /tmp? Gave you a ship it regardless, but I'm not sure this is the right strategy since the scripts should work when run alone as well. - Ben Mahler On Nov. 20, 2013, 11:23 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15741/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 11:23 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-828 > https://issues.apache.org/jira/browse/MESOS-828 > > > Repository: mesos-git > > > Description > ------- > > See bug. > > > Diffs > ----- > > src/tests/balloon_framework_test.sh > 213743fc791ef15df2f1fd1cc3682f0adb12697a > > Diff: https://reviews.apache.org/r/15741/diff/ > > > Testing > ------- > > make check (OSX) > sudo make check (Linux) > > > Thanks, > > Vinod Kone > >
