> On Nov. 21, 2013, 11:34 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp, line 114 > > <https://reviews.apache.org/r/15729/diff/1/?file=389061#file389061line114> > > > > What's the reason to concat the line no. here? Will that be useful some > > where? > > Jiang Yan Xu wrote: > It is to ensure the naming uniqueness for the 'timer' variable so if we > have multiple such MACROS in the same context they will have different names.
OK a better argument: if you already declared a TestTimer 'timer' before (and outside) the LOOP_FOR macro and within the the loop you want to use that 'timer', it will be hidden by the one declared in the MACRO. This just probabilistically prevents that from happening... - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15729/#review29263 ----------------------------------------------------------- On Nov. 20, 2013, 10:26 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15729/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 10:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-827 > https://issues.apache.org/jira/browse/MESOS-827 > > > Repository: mesos-git > > > Description > ------- > > This change is in stout. Usage of the MACRO will be posted later. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp > 1f108348797d774f935d8b34bbb864d26c83d216 > > Diff: https://reviews.apache.org/r/15729/diff/ > > > Testing > ------- > > Tested in mesos tests that use it. > > > Thanks, > > Jiang Yan Xu > >
