----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15774/#review29346 -----------------------------------------------------------
Ship it! Good riddance units.hpp! ;) - Benjamin Hindman On Nov. 22, 2013, 8:30 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15774/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 8:30 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Thomas Marshall, and > Brian Wickman. > > > Bugs: MESOS-835 > https://issues.apache.org/jira/browse/MESOS-835 > > > Repository: mesos-git > > > Description > ------- > > See the bug for details. > > > Diffs > ----- > > src/Makefile.am feda34b2d276e68f481a641d1a03d88aebc723fc > src/common/units.hpp 287dfe72f4f724f697ee311feb652bb70efa719a > src/master/constants.hpp f3a95f1006472ff2b90cabb8cf74182830740954 > src/master/constants.cpp 7bc32eb3bdae717ded63436e47031934384eec23 > src/master/hierarchical_allocator_process.hpp > b86a5a2eae18933d39d12b7eac0b07b24c4f8372 > src/master/master.hpp c86c1f1e7eb23c168bcd2e8ab0a0701c421fc59d > src/slave/cgroups_isolator.cpp 9e6421b9e56af2e98e4c663a7e0f3d97ce6b21ed > src/tests/resource_offers_tests.cpp > 2864c9a25715cd795b03f263d7c42a42b256c7bc > > Diff: https://reviews.apache.org/r/15774/diff/ > > > Testing > ------- > > make check (Linux and OSX) > > > Thanks, > > Vinod Kone > >
