----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15798/#review29347 -----------------------------------------------------------
Ship it! Awesome to see this start! - Benjamin Hindman On Nov. 22, 2013, 8:03 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15798/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 8:03 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-322 and MESOS-510 > https://issues.apache.org/jira/browse/MESOS-322 > https://issues.apache.org/jira/browse/MESOS-510 > > > Repository: mesos-git > > > Description > ------- > > This change allows requests to slaves to omit the slave(1) URL prefix for > slave endpoints. > This is a first step towards eventually being able to do the following: > > -Have tests that start multiple masters. > -Better endpoints: MESOS-322 > -Fixed local runs: MESOS-510 > > This does not fix these issues, but it partly fixes MESOS-322 and gets us > ready to alter the way we generate process id's. There are many tools that > rely on slave(1) so this provides the deprecation cycle needed to transition > any tools depending on this URL. > > > Diffs > ----- > > src/cli/mesos-cat c455427f77054255bd8589d67f77f26ab9811ad2 > src/cli/mesos-tail 432fea2a5b93352ddbfe65cb3fb9937a9334c8fb > src/slave/http.cpp 2f0bd8d63cdd3fce4e0fb401e818f828baf1447e > src/slave/main.cpp e83cd9e2892d1462db0d9110f076c3b81673075d > > Diff: https://reviews.apache.org/r/15798/diff/ > > > Testing > ------- > > make check and verified via curl that this preserves backwards compatibility: > > [bmahler@smfd-bkq-03-sr4 ~]$ curl localhost:5051/stats.json | python26 -m > json.tool > { > "failed_tasks": 0, > "finished_tasks": 0, > "invalid_status_updates": 0, > "killed_tasks": 0, > "lost_tasks": 0, > "recovery_errors": 0, > "registered": "1", > "staged_tasks": 0, > "started_tasks": 0, > "total_frameworks": 0, > "uptime": 5.5015290879999998, > "valid_status_updates": 0 > } > > [bmahler@smfd-bkq-03-sr4 ~]$ curl localhost:5051/slave\(1\)/stats.json | > python26 -m json.tool > { > "failed_tasks": 0, > "finished_tasks": 0, > "invalid_status_updates": 0, > "killed_tasks": 0, > "lost_tasks": 0, > "recovery_errors": 0, > "registered": "1", > "staged_tasks": 0, > "started_tasks": 0, > "total_frameworks": 0, > "uptime": 18.100761087999999, > "valid_status_updates": 0 > } > > > Thanks, > > Ben Mahler > >
