----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15731/#review29351 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/owned.hpp <https://reviews.apache.org/r/15731/#comment56545> CHECK_NOTNULL(data->t) << ... 3rdparty/libprocess/include/process/owned.hpp <https://reviews.apache.org/r/15731/#comment56546> Consider CHECK_NOTNULL here too. - Benjamin Hindman On Nov. 20, 2013, 10:26 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15731/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 10:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The 1st patch of the 3 patches that refactored Owned and supported > Owned::share(). > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am d3487802f9b36661162ed2d564db4593a71b3c4b > 3rdparty/libprocess/include/process/owned.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/owned_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/15731/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
