----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15319/#review29359 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/15319/#comment56558> "In other words, calling 'set' or 'fail' on this promise will not affect the result of the future that we associated." - Benjamin Hindman On Nov. 22, 2013, 6:42 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15319/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 6:42 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Say you have a process defined as follows: > > class FooProcess : public Process<FooProcess> > { > public: > Future<bool> func() { return future; } > private: > Future<bool> future; > }; > > Then you call dispatch that returns a future: > > Future<bool> f = dispatch(process, &FooProcess::func); > > If the user discards the future 'f', we expect the 'future' field in > FooProcess also being discarded. However, this is not the case currently. > > This patch fixed this issue. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp 1625d1d > > Diff: https://reviews.apache.org/r/15319/diff/ > > > Testing > ------- > > make check > > Also: > 3rdparty/libprocess/tests --gtest_repeat=1000 > > > Thanks, > > Jie Yu > >
