----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15799/#review29361 -----------------------------------------------------------
Ship it! src/log/replica.cpp <https://reviews.apache.org/r/15799/#comment56561> state.proposal = record.metadata().promised(); src/log/replica.cpp <https://reviews.apache.org/r/15799/#comment56562> state.proposal = record.promise().proposal(); MY BAD! :) (Tail between legs.) src/messages/log.proto <https://reviews.apache.org/r/15799/#comment56560> The recovery stuff really belongs in the next review. ;) - Benjamin Hindman On Nov. 22, 2013, 7:59 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15799/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 7:59 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang > Yan Xu. > > > Bugs: MESOS-736 > https://issues.apache.org/jira/browse/MESOS-736 > > > Repository: mesos-git > > > Description > ------- > > See summary. This version can be rolled out first so that we can easily roll > back if we want. > > Once this version becomes stable, we can continue our upgrade with a > following patch. > > > Diffs > ----- > > src/log/replica.cpp 59a6ff3 > src/messages/log.proto 3d5859f > > Diff: https://reviews.apache.org/r/15799/diff/ > > > Testing > ------- > > make check > > bin/mesos-tests.sh > --gtest_filter=LogTest.*:ReplicaTest.*:CoordinatorTest.*:LogZooKeeperTest.* > --gtest_repeat=100 > > > Thanks, > > Jie Yu > >
