> On Nov. 25, 2013, 2:30 a.m., Benjamin Hindman wrote: > > src/Makefile.am, line 261 > > <https://reviews.apache.org/r/15169/diff/2/?file=376203#file376203line261> > > > > Cool! Is it easy to determine the tag too? That would save one extra > > git command for people trying to answer email questions and is likely > > fairly common since people will checkout x.y.z-rcN tags. > > Niklas Nielsen wrote: > Yep - `git describe 2> /dev/null` :) So have that as an extra field e.g. > git_tag ?
Yes please :) Should we use: git describe --exact ? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15169/#review29358 ----------------------------------------------------------- On Nov. 1, 2013, 3:58 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15169/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 3:58 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Exposing build revisions and branch names can help diagnosing problems with > slaves and masters in development settings. > > This patch fetches git sha and branch of repo (if available) and fills option > variables BUILD_GIT_SHA and BUILD_GIT_BRANCH accordingly. > If variables are set, master and slave state.json expose and sets fields > "git_sha" and "git_branch". > > > Diffs > ----- > > configure.ac ac3f7f7 > src/Makefile.am a11c76b > src/common/build.hpp c0e2a64 > src/common/build.cpp 960b017 > src/master/http.cpp f2a535a > src/slave/http.cpp 62fbb37 > > Diff: https://reviews.apache.org/r/15169/diff/ > > > Testing > ------- > > make check > > Functional testing of: > 1) Development version (from git repo) -> Shows correct git hash and branch > 2) Distribution version (from make dist) -> Does *not* show git hash and > branch fields in state.json > > > Thanks, > > Niklas Nielsen > >
