> On Nov. 27, 2013, 6:47 p.m., Benjamin Hindman wrote: > > src/sched/sched.cpp, lines 748-756 > > <https://reviews.apache.org/r/15872/diff/1/?file=391426#file391426line748> > > > > Want to fix this too? ;)
Gah! Thanks for reminding me, fixed this with an if/else to preserve the existing VLOG message. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15872/#review29496 ----------------------------------------------------------- On Nov. 27, 2013, 7:04 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15872/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 7:04 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-851 > https://issues.apache.org/jira/browse/MESOS-851 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-851. > > Now once a call to SchedulerDriver::abort() is issued, we begin ignoring > messages that were queued in the driver. Previously, we would have to process > the entire queue of messages, which can result in many calls to the > Scheduler, despite abort() already having been called. > > This ensures that once abort() is called, we ignore queued messages while > still processing queued requests *from* the scheduler. > > The same change here was applied to the ExecutorDriver. > > > Diffs > ----- > > src/exec/exec.cpp a58203b1ce85af9711dc207c34e7bc673c5441b1 > src/sched/sched.cpp af57f284b715e1498fd4b2a317706bc33792dec3 > > Diff: https://reviews.apache.org/r/15872/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
