Sorry for the trouble! I could submit this and clean up the whitespace for you, but I think this will be a good exercise in using reviewboard. :)
Updating will, as far as I know, result in a new revision in the diff page, but there is only one diff revision: https://reviews.apache.org/r/15764/diff/#index_header Looking at the diff page, there is only one revision, and it has the trailing whitespace. The raw diff also has the trailing whitespace, so it doesn't appear as if the diff has been updated: https://reviews.apache.org/r/15764/diff/raw/ When you publish a new diff successfully, you will see a 'Review request changed' update on the review, see https://reviews.apache.org/r/15708/ for an example (after Vinod's review I uploaded a new diff). On Mon, Dec 9, 2013 at 2:05 PM, Timothy St. Clair <[email protected]>wrote: > > > > On Nov. 22, 2013, 9:51 p.m., Ben Mahler wrote: > > > Interesting, these files are not meant to be scripts (they are python > libraries), which tool reported the script-without-shebang issue? > > > > > > (Can you kill the trailing whitespace in the Apache header?) > > > > Timothy St. Clair wrote: > > rpmlint generated on recent update ( > https://bugzilla.redhat.com/show_bug.cgi?id=1010512#c6). It checks the > contents of the install targets. > > > > Timothy St. Clair wrote: > > Updated patch to remove minor trailing spaces. There were only a > couple. > > > > Ben Mahler wrote: > > Did you forget to update the patch? > > This is my 1st time using the review board, I used "Update Diff" to update > the patch. When I download the diff it appears correct "updated", with no > extra lines or spaces. Is there a different workflow that I should be > following? If so url please? > > > - Timothy > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15764/#review29316 > ----------------------------------------------------------- > > > On Nov. 21, 2013, 7:07 p.m., Timothy St. Clair wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/15764/ > > ----------------------------------------------------------- > > > > (Updated Nov. 21, 2013, 7:07 p.m.) > > > > > > Review request for mesos. > > > > > > Bugs: MESOS-831 > > https://issues.apache.org/jira/browse/MESOS-831 > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > Minor modification to python scripts. > > > > > > Diffs > > ----- > > > > src/cli/python/mesos/__init__.py > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > src/cli/python/mesos/cli.py 5c11d4664de4314674cb49cf534e334a0663b254 > > src/cli/python/mesos/futures.py > be374cf0235de75f7201b3e8078af8cef620dc2f > > src/cli/python/mesos/http.py 9db9e23c731c4306ff3866c07963a19c196f758c > > > > Diff: https://reviews.apache.org/r/15764/diff/ > > > > > > Testing > > ------- > > > > n/a > > > > > > Thanks, > > > > Timothy St. Clair > > > > > >
