> On Dec. 9, 2013, 9:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 849 > > <https://reviews.apache.org/r/15653/diff/4/?file=395223#file395223line849> > > > > Should this be ErrnoError?
getloadavg is most likely just a wrapper for sysctl (which sets errno), so yes - should probably be ErrnoError. I will get this in the new patch. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15653/#review30045 ----------------------------------------------------------- On Dec. 6, 2013, 11:22 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15653/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2013, 11:22 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This patch includes a wrapper to get system load averages in uptime(1) > format. This is used by an upcoming patch which expose these averages > over master and slave stats.json endpoints. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 544cf8c > > Diff: https://reviews.apache.org/r/15653/diff/ > > > Testing > ------- > > make check and functional testing with endpoints. > > > Thanks, > > Niklas Nielsen > >
