> On Dec. 10, 2013, 6:38 a.m., Benjamin Hindman wrote: > > src/log/log.cpp, line 817 > > <https://reviews.apache.org/r/15802/diff/5/?file=394481#file394481line817> > > > > I'd prefer to keep these "timeouts" be of type Timeout not Duration (in > > all these methods).
One inconsistency I found in the original code is: functions like append/truncate takes a Timeout, while the Log::Writer constructor takes a Duration (I guess in this case, it does't make sense to take a Timeout). Therefore, to be consistent, I made them all Durations. Any particular reason to use Timeout? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/#review29966 ----------------------------------------------------------- On Dec. 5, 2013, 7:28 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15802/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 7:28 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang > Yan Xu. > > > Bugs: MESOS-736 > https://issues.apache.org/jira/browse/MESOS-736 > > > Repository: mesos-git > > > Description > ------- > > This is the last patch of a series of patches that implement catch-up > replicated log. > > Here is summary of this patch: > 1) Introduced RecoverRequest/RecoverResponse. > 2) Used Metadata in replica code. > 3) A 2-phase empty log start-up algorithm. > 4) Added a test to test two competing recover processes. > > This is a joint work with Yan Xu. > > > Diffs > ----- > > src/Makefile.am abef3d2 > src/java/jni/org_apache_mesos_Log.cpp 36c636d > src/log/coordinator.hpp 3f6fb7c > src/log/coordinator.cpp 6e6466f > src/log/log.hpp 77edc7a > src/log/log.cpp d057925 > src/log/recover.hpp PRE-CREATION > src/log/recover.cpp PRE-CREATION > src/log/replica.hpp d1f5ead > src/log/replica.cpp 82c2157 > src/messages/log.proto e6460ab > src/tests/log_tests.cpp ff5f86c > > Diff: https://reviews.apache.org/r/15802/diff/ > > > Testing > ------- > > make check > > bin/mesos-tests.sh > --gtest_filter=LogTest.*:ReplicaTest.*:CoordinatorTest.*:LogZooKeeperTest.* > --gtest_repeat=100 > > > Thanks, > > Jie Yu > >
