> On Dec. 12, 2013, 9:58 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 115 > > <https://reviews.apache.org/r/16225/diff/1/?file=397015#file397015line115> > > > > Wouldn't the implicit Option constructor have worked instead of needing > > overloads?
Probably because 'min' is a template function and it's not instantiated yet. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16225/#review30287 ----------------------------------------------------------- On Dec. 12, 2013, 9:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16225/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 9:49 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp f93bc15 > 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp be56d1f > > Diff: https://reviews.apache.org/r/16225/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
