----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16235/#review30332 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/16235/#comment58062> s/likely/possible/ ? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/16235/#comment58060> what about logging a warning for posix if current_time < boot_time? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/16235/#comment58061> Move endutxent() above here so it's always closed? - Ian Downes On Dec. 13, 2013, 4:25 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16235/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 4:25 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-844 > https://issues.apache.org/jira/browse/MESOS-844 > > > Repository: mesos-git > > > Description > ------- > > This can be used to identify a reboot, should the boot id change. > > For POSIX systems, the boot time in seconds is used as a good approximation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 2382d40a51036782e09e1fc3123c8791834510ea > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > a0b624b0c2e1f1fca6dd68a54317f6c0c11e7862 > > Diff: https://reviews.apache.org/r/16235/diff/ > > > Testing > ------- > > Added a test, make check on OS X and CentOS 5. > > > Thanks, > > Ben Mahler > >
